getspentzerocoinamount RPC call. #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
presstab
suggested changes
Nov 15, 2017
src/rpcrawtransaction.cpp
Outdated
| if (!input.scriptSig.IsZerocoinSpend()) | ||
| return -1; | ||
|
|
||
| std::vector<char, zero_after_free_allocator<char> > dataTxIn; |
There was a problem hiding this comment.
Can simplify this code:
libzerocoin::CoinSpend spend = TxInToZerocoinSpend(input);
src/rpcrawtransaction.cpp
Outdated
| dataTxIn.insert(dataTxIn.end(), input.scriptSig.begin() + 4, input.scriptSig.end()); | ||
| CDataStream serializedCoinSpend(dataTxIn, SER_NETWORK, PROTOCOL_VERSION); | ||
| libzerocoin::CoinSpend spend(Params().Zerocoin_Params(), serializedCoinSpend); | ||
| return libzerocoin::ZerocoinDenominationToAmount(spend.getDenomination()); |
There was a problem hiding this comment.
Should return the formatted version of the value. Most people have a hard time figuring out pivtoshis.
CAmount nValue = libzerocoin::ZerocoinDenominationToAmount(spend.getDenomination());
return FormatMoney(nValue);
|
Implemented requested changes |
presstab
approved these changes
Nov 21, 2017
Accepts transaction hash and input index as parameters and returns amount of spent zerocoin input (if input is not zerocoin spend, returns -1). Return value in pivs, not pivtoshis.
Fuzzbawls
force-pushed
the
getspentzerocoinamount
branch
from
3e42806
to
0c38407
Compare
ghost
assigned 
|
Rebased/Squashed into a single commit for merging |
Fuzzbawls
added a commit
that referenced
this pull request
Nov 29, 2017
0c38407 Add getspentzerocoinamount RPC call (whateverpal) Tree-SHA512: 25222e480697db965cb762ff3ce26a28d3e07b3b03bfe0a7d82aeed40ca43ea7af81c827586896a82ab0cc02027e6ae2226ae73510b7ad49e17292099c2720da
Fuzzbawls
pushed a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Nov 29, 2017
Accepts transaction hash and input index as parameters and returns amount of spent zerocoin input (if input is not zerocoin spend, returns -1). Return value in pivs, not pivtoshis. Github-Merge: PIVX-Project#385 Rebased-From: 0c38407
meyer9
pushed a commit
to phoreproject/Phore
that referenced
this pull request
Feb 15, 2018
Accepts transaction hash and input index as parameters and returns amount of spent zerocoin input (if input is not zerocoin spend, returns -1). Return value in pivs, not pivtoshis. Github-Merge: PIVX-Project#385 Rebased-From: 0c38407
meyer9
pushed a commit
to phoreproject/Phore
that referenced
this pull request
Feb 20, 2018
Accepts transaction hash and input index as parameters and returns amount of spent zerocoin input (if input is not zerocoin spend, returns -1). Return value in pivs, not pivtoshis. Github-Merge: PIVX-Project#385 Rebased-From: 0c38407
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accepts transaction hash and input index as parameters and returns amount of spent zerocoin input (if input is not zerocoin spend, returns -1).