Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Main] Avoid slow transaction search with txindex enabled #395

Merged
merged 1 commit into from
Nov 29, 2017

Conversation

Fuzzbawls
Copy link
Collaborator

There is no point in doing a "slow" search for a transaction if it isn't
found in the txindex (if enabled).

We run with txindex enabled by default, so this could see some performance increase in the form of faster response times when searching for a transaction that doesn't exist.

There is no point in doing a "slow" search for a transaction if it isn't
found in the txindex (if enabled).
@ghost ghost assigned Fuzzbawls Nov 17, 2017
@ghost ghost added the review label Nov 17, 2017
@PIVX-Project PIVX-Project added this to the 3.0.6 milestone Nov 20, 2017
@jonspock
Copy link

utACK

@presstab
Copy link

ACK. reindex=1 worked fine with this, as well as general use of the wallet.

@presstab presstab merged commit c507dc1 into PIVX-Project:master Nov 29, 2017
presstab added a commit that referenced this pull request Nov 29, 2017
c507dc1 [Main] Avoid slow transaction search with txindex enabled (Fuzzbawls)

Tree-SHA512: de1b78e8993b9e77015335bbd99f8716dacbf07313eeaae9ff4307703b15c8b746852052ab8d566b1418b1daf85513bf102719ed37b03691d44af8d7f363493e
@ghost ghost removed the review label Nov 29, 2017
Fuzzbawls added a commit to Fuzzbawls/PIVX that referenced this pull request Nov 29, 2017
There is no point in doing a "slow" search for a transaction if it isn't
found in the txindex (if enabled).

Github-Merge: PIVX-Project#395
Rebased-From: c507dc1
@Fuzzbawls Fuzzbawls deleted the 2017_txsearch branch November 30, 2017 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants