Change git info in genbuild.sh #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-release source builds
ghost
assigned 
|
utACK and merging... |
Mrs-X
added a commit
that referenced
this pull request
Nov 24, 2017
8fa5f12 Change git commands called so we can get a better description for non-release source builds (Jon Spock) Tree-SHA512: fed718c2943fd43a35b41ddf2b00577d00d64fed292d7dd0cd9866587c61b4c0278a4bd2ddbe134e5ccc3f3841751e099dc0fef596834eaad310356f33ad0bbe
Fuzzbawls
pushed a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Nov 29, 2017
…-release source builds Github-Merge: PIVX-Project#402 Rebased-From: 8fa5f12
meyer9
pushed a commit
to phoreproject/Phore
that referenced
this pull request
Feb 15, 2018
…-release source builds Github-Merge: PIVX-Project#402 Rebased-From: 8fa5f12
Fuzzbawls
added a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Mar 5, 2018
The previous change required tagging on `master`, which we don't do. As a result, the version string displayed in-wallet was always displaying based off of a dummy tag that was pushed during the review of PIVX-Project#402. This PR restores the functionality to generate the version string without relying on superficial tags. This reverts commit 8fa5f12.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This slightly changes the usage of git calls in genbuild.sh to get a better description of what is built during development / building. Rather than just always get 3.0.99-g8fa5f125e, you'll get something more descriptive such as '3.0.5.1-branchpoint-1-g8fa5f125e', where the '1' is the number of commits after the "3.0.5.1-branchpoint" tag. This also makes it easier to locate the commit in the git tree and compare to others who are using slightly different versions.
Since this is only using git calls from a shell script it should work on all of the same platforms as the current script.
As before, when we build from a tag for releases then you should simply get something like "v3.0.6" without the extra fields.
Finally I believe this tag/description just goes to the splash screen and for internal usage - not to other peers.
This is a simpler change than PR #310