forked from dashpay/dash
-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Double check tx size when creating zPIV tx's. #412
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned presstab
Nov 25, 2017
ghost
added
the
review
label
Nov 25, 2017
Mrs-X
suggested changes
Nov 25, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Transaction size too large..." should be made translatable.
Oh, and while you're at it, the other receipt.SetStatus
also need a tr()
or _()
(whichever is used in this context)
It is possible for a spend of 7 to be larger than the max transaction size. Catch these cases and send a correct error report up the chain to the GUI.
presstab
force-pushed
the
zpiv_txsize_check
branch
from
November 26, 2017 21:03
2926095
to
0983755
Compare
Updated text to use |
presstab
added a commit
that referenced
this pull request
Nov 26, 2017
0983755 Double check tx size when creating zPIV tx's. (presstab) Tree-SHA512: 7a91f4a6c69107556e0d628a63aea8428568262fa3a6c1b124376493f0eb0e709e66d420153cc755298440556e10569e89c08d1099cde8d7ce3250c2c4181d01
ghost
removed
the
review
label
Nov 26, 2017
Fuzzbawls
pushed a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Nov 29, 2017
It is possible for a spend of 7 to be larger than the max transaction size. Catch these cases and send a correct error report up the chain to the GUI. Github-Merge: PIVX-Project#412 Rebased-From: 0983755
meyer9
pushed a commit
to phoreproject/Phore
that referenced
this pull request
Feb 15, 2018
It is possible for a spend of 7 to be larger than the max transaction size. Catch these cases and send a correct error report up the chain to the GUI. Github-Merge: PIVX-Project#412 Rebased-From: 0983755
meyer9
pushed a commit
to phoreproject/Phore
that referenced
this pull request
Feb 20, 2018
It is possible for a spend of 7 to be larger than the max transaction size. Catch these cases and send a correct error report up the chain to the GUI. Github-Merge: PIVX-Project#412 Rebased-From: 0983755
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible for a spend of 7 to be larger than the max transaction size. Catch these cases and send a correct error report up the chain to the GUI.