Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double check tx size when creating zPIV tx's. #412

Merged
merged 1 commit into from
Nov 26, 2017

Conversation

presstab
Copy link

It is possible for a spend of 7 to be larger than the max transaction size. Catch these cases and send a correct error report up the chain to the GUI.

@ghost ghost assigned presstab Nov 25, 2017
@ghost ghost added the review label Nov 25, 2017
Copy link

@Mrs-X Mrs-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Transaction size too large..." should be made translatable.

Oh, and while you're at it, the other receipt.SetStatus also need a tr() or _() (whichever is used in this context)

It is possible for a spend of 7 to be larger than the max transaction size. Catch these cases and send a correct error report up the chain to the GUI.
@presstab
Copy link
Author

Updated text to use _() and wording to be as @jonspock suggested in slack channel. Merging now.

@presstab presstab merged commit 0983755 into PIVX-Project:master Nov 26, 2017
presstab added a commit that referenced this pull request Nov 26, 2017
0983755 Double check tx size when creating zPIV tx's. (presstab)

Tree-SHA512: 7a91f4a6c69107556e0d628a63aea8428568262fa3a6c1b124376493f0eb0e709e66d420153cc755298440556e10569e89c08d1099cde8d7ce3250c2c4181d01
@ghost ghost removed the review label Nov 26, 2017
@Fuzzbawls Fuzzbawls added this to the 3.0.6 milestone Nov 29, 2017
Fuzzbawls pushed a commit to Fuzzbawls/PIVX that referenced this pull request Nov 29, 2017
It is possible for a spend of 7 to be larger than the max transaction size. Catch these cases and send a correct error report up the chain to the GUI.

Github-Merge: PIVX-Project#412
Rebased-From: 0983755
meyer9 pushed a commit to phoreproject/Phore that referenced this pull request Feb 15, 2018
It is possible for a spend of 7 to be larger than the max transaction size. Catch these cases and send a correct error report up the chain to the GUI.

Github-Merge: PIVX-Project#412
Rebased-From: 0983755
meyer9 pushed a commit to phoreproject/Phore that referenced this pull request Feb 20, 2018
It is possible for a spend of 7 to be larger than the max transaction size. Catch these cases and send a correct error report up the chain to the GUI.

Github-Merge: PIVX-Project#412
Rebased-From: 0983755
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants