Fix edge case segfault. #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to access a map element that DNE if you force quit without downloading any blocks and then restart the wallet.
ghost
assigned 
|
I'll try to use-test this tomorrow, however if you have any insight as to exactly when to force quite a client to force the situation that would be great :) |
|
I tested this with the same 3 faulty db states that I used to test #405 as well as the case that causes the segfault. The more testing the better though! |
presstab
added a commit
that referenced
this pull request
Nov 29, 2017
a698e37 Fix edge case segfault. (presstab) Tree-SHA512: cf3df3c6c5e1e36b5c78fd6506b2304c4a714e9c302d9cf18b93e1d9980f95057dcc1e69132ca9408a5d989380e83f90c9fb464a822d4863f35a20f58f45c193
Fuzzbawls
pushed a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Nov 29, 2017
It is possible to access a map element that DNE if you force quit without downloading any blocks and then restart the wallet. Github-Merge: PIVX-Project#418 Rebased-From: a698e37
meyer9
pushed a commit
to phoreproject/Phore
that referenced
this pull request
Feb 15, 2018
It is possible to access a map element that DNE if you force quit without downloading any blocks and then restart the wallet. Github-Merge: PIVX-Project#418 Rebased-From: a698e37
meyer9
pushed a commit
to phoreproject/Phore
that referenced
this pull request
Feb 20, 2018
It is possible to access a map element that DNE if you force quit without downloading any blocks and then restart the wallet. Github-Merge: PIVX-Project#418 Rebased-From: a698e37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to access a map element that DNE if you force quit without downloading any blocks and then restart the wallet.