In-Wallet Masternode management #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready to merge. |
|
Tested and excellent. Great work. |
random-zebra
pushed a commit
to random-zebra/PIVX
that referenced
this pull request
Feb 13, 2019
[Tests] fix proof of stake target in block class
random-zebra
added a commit
that referenced
this pull request
Mar 18, 2020
…sRow 359f70e [GUI] Explicit cast from quint32 to bool in filterAcceptsRow (random-zebra) Pull request description: This is a (hopefully definitive) fix for a strange segfault I was consistently having on testnet with the GUI wallet (during the loading of the stake charts), with the following stacktrace ``` #0 0x00007ffff58363bb in () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #1 0x00007ffff583b25d in () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #2 0x00007ffff583b932 in () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #3 0x00007ffff583bca9 in () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #4 0x00007ffff583c50a in QSortFilterProxyModel::invalidateFilter() () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #5 0x00005555556aa809 in DashboardWidget::updateStakeFilter() (this=this@entry=0x5555577817d0) at qt/pivx/dashboardwidget.cpp:480 #6 0x00005555556ac736 in DashboardWidget::getAmountBy() (this=this@entry=0x5555577817d0) at qt/pivx/dashboardwidget.cpp:503 #7 0x00005555556ad1a1 in DashboardWidget::loadChartData(bool) (this=this@entry=0x5555577817d0, withMonthNames=false) at qt/pivx/dashboardwidget.cpp:556 #8 0x00005555556ad703 in DashboardWidget::run(int) (this=0x5555577817d0, type=<optimized out>) at qt/pivx/dashboardwidget.cpp:812 #9 0x00005555557641d4 in Worker::process() (this=0x5555576314c0) at qt/pivx/loadingdialog.cpp:12 #10 0x00007ffff56932b2 in () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #11 0x00007ffff569617d in () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #12 0x00007ffff4ae36db in start_thread (arg=0x7ffe61ffb700) at pthread_create.c:463 #13 0x00007ffff2c9e88f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95 ``` Explicit the cast to bool when checking the transaction type in `TransactionFilterProxy::filterAcceptsRow`. ACKs for top commit: furszy: detective work 👍 , utACK 359f70e. Fuzzbawls: utACK 359f70e then Tree-SHA512: f1481a0545fb1ebe62b28232f9257e6c52306ff15dd1dcefc29d4eeb3dd25b7231d48416cad528e720fb68aa192b089e14bfc8ee92e55406ea02fc777f552b15
Fuzzbawls
added a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Sep 23, 2020
98261b1 Merge PIVX-Project#22: Clamp JSON object depth to PHP limit 54c4015 Clamp JSON object depth to PHP limit 5a58a46 Merge PIVX-Project#21: Remove hand-coded UniValue destructor. b4cdfc4 Remove hand-coded UniValue destructor. 7fba60b Merge PIVX-Project#17: [docs] Update readme 4577454 Merge PIVX-Project#13: Fix typo ac7e73c [docs] Update readme 7890db9 Merge PIVX-Project#11: Remove deprecated std pair wrappers 40e3485 Merge PIVX-Project#14: Cleaned up namespace imports to reduce symbol collisions 4a49647 Fix typo 85052a4 Remove deprecated std::pair wrappers 51d3ab3 Merge PIVX-Project#10: Add pushKV(key, boolean) function (replaces PIVX-Project#5) 129bad9 [tests] test pushKV for boolean values b3c44c9 Pushing boolean value to univalue correctly 07947ff Merge PIVX-Project#9: [tests] Fix BOOST_CHECK_THROW macro ec849d9 [tests] Fix BOOST_CHECK_THROW macro d208f98 Cleaned up namespace imports to reduce symbol collisions 31bc9f5 Merge PIVX-Project#8: Remove unused Homebrew workaround fa04209 Remove HomeBrew workaround a523e08 Merge PIVX-Project#7: Declare single-argument (non-converting) constructors "explicit" a9e53b3 Merge PIVX-Project#4: Pull upstream fe805ea Declare single-argument (non-converting) constructors "explicit" 8a2d6f1 Merge pull request PIVX-Project#41 from jgarzik/get-obj-map ba341a2 Add getObjMap() helper method. Also, constify checkObject(). ceb1194 Handle .pushKV() and .checkObject() edge cases. 107db98 Add ::push_back(double) method for feature parity. d415300 Move one-line implementation of UniValue::read() to header. 52e85b3 Move exception-throwing get_* methods into separate implementation module. 16a1f7f Merge PIVX-Project#3: Pull upstream daf1285 Merge pull request PIVX-Project#2 from jgarzik/master f32df99 Merge branch '2016_04_unicode' into bitcoin 280b191 Merge remote-tracking branch 'jgarzik/master' into bitcoin 2740c4f Merge branch '2015_11_escape_plan' into bitcoin git-subtree-dir: src/univalue git-subtree-split: 98261b1
Fuzzbawls
added a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Sep 24, 2020
98261b1 Merge PIVX-Project#22: Clamp JSON object depth to PHP limit 54c4015 Clamp JSON object depth to PHP limit 5a58a46 Merge PIVX-Project#21: Remove hand-coded UniValue destructor. b4cdfc4 Remove hand-coded UniValue destructor. 7fba60b Merge PIVX-Project#17: [docs] Update readme 4577454 Merge PIVX-Project#13: Fix typo ac7e73c [docs] Update readme 7890db9 Merge PIVX-Project#11: Remove deprecated std pair wrappers 40e3485 Merge PIVX-Project#14: Cleaned up namespace imports to reduce symbol collisions 4a49647 Fix typo 85052a4 Remove deprecated std::pair wrappers 51d3ab3 Merge PIVX-Project#10: Add pushKV(key, boolean) function (replaces PIVX-Project#5) 129bad9 [tests] test pushKV for boolean values b3c44c9 Pushing boolean value to univalue correctly 07947ff Merge PIVX-Project#9: [tests] Fix BOOST_CHECK_THROW macro ec849d9 [tests] Fix BOOST_CHECK_THROW macro d208f98 Cleaned up namespace imports to reduce symbol collisions 31bc9f5 Merge PIVX-Project#8: Remove unused Homebrew workaround fa04209 Remove HomeBrew workaround a523e08 Merge PIVX-Project#7: Declare single-argument (non-converting) constructors "explicit" a9e53b3 Merge PIVX-Project#4: Pull upstream fe805ea Declare single-argument (non-converting) constructors "explicit" 8a2d6f1 Merge pull request PIVX-Project#41 from jgarzik/get-obj-map ba341a2 Add getObjMap() helper method. Also, constify checkObject(). ceb1194 Handle .pushKV() and .checkObject() edge cases. 107db98 Add ::push_back(double) method for feature parity. d415300 Move one-line implementation of UniValue::read() to header. 52e85b3 Move exception-throwing get_* methods into separate implementation module. 16a1f7f Merge PIVX-Project#3: Pull upstream daf1285 Merge pull request PIVX-Project#2 from jgarzik/master f32df99 Merge branch '2016_04_unicode' into bitcoin 280b191 Merge remote-tracking branch 'jgarzik/master' into bitcoin 2740c4f Merge branch '2015_11_escape_plan' into bitcoin git-subtree-dir: src/univalue git-subtree-split: 98261b1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation allows you to:
1: watch and start/re-start your masternodes from within the Darknet wallet
2: have a properly formatted list of all masternodes in your wallet
The masternodes listed under "My Masternodes" are the ones maintained in the "masternode.conf" file in your wallets data directory. Single masternodes configured via darknet.conf are NOT listed there.
You can switch on/off the masternode tab under Settings -> Options -> Wallet.
Teaser:
Tab "My Masternodes":
Tab "All Masternodes":
Please test, feedback especially of the Windows and OSX versions would be nice.