Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Trivial] typo fixes #951

Merged
merged 2 commits into from
Jul 29, 2019
Merged

[Trivial] typo fixes #951

merged 2 commits into from
Jul 29, 2019

Conversation

CaveSpectre11
Copy link

"monthly" instead of "monthy"
"budget" instead of "buddget"

Also included "std::" on the throw runtime_error for a smoother merge with #949

@CaveSpectre11
Copy link
Author

Also fixed spelling of "advertise"

@Fuzzbawls Fuzzbawls added this to the 4.0.0 milestone Jul 14, 2019
Fuzzbawls
Fuzzbawls approved these changes Jul 26, 2019
View reviewed changes
Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7493038

Fuzzbawls
Fuzzbawls requested changes Jul 26, 2019
View reviewed changes
Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a quick rebase

git pull --rebase origin master

@CaveSpectre11
Copy link
Author

Needs a quick rebase

git pull --rebase origin master

Taken care of

random-zebra
random-zebra approved these changes Jul 26, 2019
View reviewed changes
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Fuzzbawls
Fuzzbawls approved these changes Jul 27, 2019
View reviewed changes
Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 639b43d

@Fuzzbawls Fuzzbawls merged commit 639b43d into PIVX-Project:master Jul 29, 2019
Fuzzbawls added a commit that referenced this pull request Jul 29, 2019
@Fuzzbawls
Merge #951: [Trivial] typo fixes
fa40040 
639b43d [Trivial] Spelling - Wither -> Whether (Cave Spectre)
c9a2cc3 Trivial: typo fixes (Cave Spectre)

Pull request description:

  "monthly" instead of "monthy"
  "budget" instead of "buddget"

  Also included "std::" on the throw runtime_error for a smoother merge with #949

ACKs for top commit:
  Fuzzbawls:
    ACK 639b43d

Tree-SHA512: 3e6d72e4842c4e2100e6252b4b452da9368c76583dee9bf7427e73fc1f8115fbcd059bd7869d7f43e9b40f7026a65b07a0d916f6fc9df5f76c93eb08145437dc
@CaveSpectre11 CaveSpectre11 mentioned this pull request Jul 31, 2019
Merged
@Fuzzbawls Fuzzbawls mentioned this pull request Aug 1, 2019
Merged
@CaveSpectre11 CaveSpectre11 deleted the budget-typo branch August 9, 2019 01:21
@random-zebra random-zebra modified the milestones: 4.0.0, 3.4.0 Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fuzzbawls Fuzzbawls Fuzzbawls approved these changes

@random-zebra random-zebra random-zebra approved these changes

Assignees

@CaveSpectre11 CaveSpectre11

Labels
Cleanup NoFunctionalChanges
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@CaveSpectre11 @Fuzzbawls @random-zebra