BRR decoding improvements and some cleanup #18
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines some general refactoring of brr.c with a new feature that fixes the way instruments 17 and 19 sound. It's not really cleaned up yet but I wanted to create a PR before the week ended. Sorry about that.
Included in the first commit is code to handle failure for malloc, and the second commit includes realloc as well. There's a to-do comment left in the code about what to do if realloc fails. Right now, it just treats it the same way as the case where a cycle couldn't be found: it creates a loop segment with the last decoded loop portion of the sample. I'm interested in different ideas for what to do there, including whether doing nothing (like the rest of EBMusEd's code) is preferred.