-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pid-lagrange, test): add algo and update test #210
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## dev #210 +/- ##
==========================================
+ Coverage 88.61% 95.41% +6.80%
==========================================
Files 90 98 +8
Lines 4444 4323 -121
==========================================
+ Hits 3938 4125 +187
+ Misses 506 198 -308
... and 19 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
omnisafe/algorithms/on_policy/early_terminated/ppo_early_terminated.py
Outdated
Show resolved
Hide resolved
omnisafe/algorithms/on_policy/early_terminated/trpo_early_terminated.py
Outdated
Show resolved
Hide resolved
@@ -61,7 +61,7 @@ | |||
parser.add_argument( | |||
'--vector-env-nums', | |||
type=int, | |||
default=2, | |||
default=1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default value of vector-env-nums
needs to be 1 because the early-terminated algorithms does not support vector environments. The original default value 2 will trigger error, so we set 1 instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Description
tests
filesTypes of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!
make format
. (required)make lint
. (required)make test
pass. (required)