-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support metadrive env #328
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #328 +/- ##
==========================================
- Coverage 96.84% 96.83% -0.01%
==========================================
Files 138 138
Lines 7060 7071 +11
==========================================
+ Hits 6837 6847 +10
- Misses 223 224 +1 ☔ View full report in Codecov by Sentry. |
muchvo
reviewed
May 4, 2024
muchvo
approved these changes
May 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is already complete in terms of implementation accuracy. We will merge it shortly after improving the code style and documentation.
This PR supports
SafeMetaDrive
from MetaDrive[1].[1]: Metadrive: Composing diverse driving scenarios for generalizable reinforcement learning
Autonomous driving is an important application of reinforcement learning algorithms, and safety is particularly crucial. Safety constraints for autonomous driving tasks are an important research direction in the SafeRL field. We have implemented the embedding of SafeMetaDrive based on our customized environment interface (more details in #310 ) and presented the SafeRL baseline algorithms involved in the MetaDrive paper as follows, hoping to inspire research on related algorithms.
Motivation and Context
Related issues can be found at #262
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!
make format
. (required)make lint
. (required)make test
pass. (required)