Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(gymnasium): update gymnasium version to 0.28.1 #41

Merged
merged 5 commits into from
Apr 15, 2023

Conversation

muchvo
Copy link
Collaborator

@muchvo muchvo commented Apr 13, 2023

Description

  1. Update gymnasium version to 0.28.1

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@muchvo muchvo linked an issue Apr 13, 2023 that may be closed by this pull request
2 tasks
zmsn-2077
zmsn-2077 previously approved these changes Apr 13, 2023
Copy link
Member

@zmsn-2077 zmsn-2077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zmsn-2077
Copy link
Member

It's time to bump the version to 0.3.0 after the PR #16 finishes.

@muchvo
Copy link
Collaborator Author

muchvo commented Apr 13, 2023

It's time to bump the version to 0.3.0 after the PR #16 finishes.

got it

README.md Show resolved Hide resolved
Copy link
Member

@Gaiejj Gaiejj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@muchvo muchvo merged commit 57174cc into PKU-Alignment:main Apr 15, 2023
@muchvo muchvo deleted the update_gym branch April 15, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] upgrade to gymnasium 28.1
3 participants