Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): 登录页面增加必填校验,增加 logo #522

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

tongchong
Copy link
Contributor

如下图,修改后登录页面后,点击登录会先校验必填输入框是否已填写,未填写会提醒,增加了logo,引用的平台中的logo地址“/api/logo?type=logo&preferDark=false”。
6fb2d6f9-e59d-46bd-b437-d1dd2a1e8e9e

@tongchong tongchong requested a review from ddadaal March 21, 2023 09:18
@changeset-bot
Copy link

changeset-bot bot commented Mar 21, 2023

🦋 Changeset detected

Latest commit: 8f36afe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@scow/auth Patch
@scow/gateway Patch
@scow/mis-server Patch
@scow/mis-web Patch
@scow/portal-server Patch
@scow/portal-web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tongchong tongchong changed the title 登录页面增加必填校验,增加 logo fix(auth): 登录页面增加必填校验,增加 logo Mar 21, 2023
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5a06987) 67.02% compared to head (8f36afe) 67.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #522   +/-   ##
=======================================
  Coverage   67.02%   67.02%           
=======================================
  Files         115      115           
  Lines        3133     3133           
  Branches      391      391           
=======================================
  Hits         2100     2100           
  Misses        980      980           
  Partials       53       53           
Impacted Files Coverage Δ
apps/auth/src/auth/loginHtml.ts 70.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ddadaal ddadaal merged commit ac298dc into master Mar 22, 2023
@ddadaal ddadaal deleted the fix-auth-login branch March 22, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants