Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling null proxy domain, and allowing extra curl options #340

Merged
merged 11 commits into from
Nov 6, 2020
Merged

Handling null proxy domain, and allowing extra curl options #340

merged 11 commits into from
Nov 6, 2020

Conversation

alfirrell
Copy link
Contributor

Fixing issue 339

@alfirrell
Handle null proxy domain and extra curl options
ea321b6 
Omit the \\ if proxy domain param is null, add arbitrary extra named curl options (e.g. list(timeout=60))
@alfirrell
Add arbitrary extra curl options
d0eee5d
@PMassicotte
Copy link
Owner

The documentation has not been update.

Codoc mismatches from documentation object 'setHandleParameters':
setHandleParameters
  Code: function(user = NULL, password = NULL, domain = NULL, proxyhost
                 = NULL, proxyport = 8080, proxyauth = 15,
                 extra_curl_opts = list())
  Docs: function(user = NULL, password = NULL, domain = NULL, proxyhost
                 = NULL, proxyport = 8080, proxyauth = 15)
  Argument names in code not in docs:
    extra_curl_opts

@alfirrell
Copy link
Contributor Author

Sorry - sorting this now, will update shortly.

@alfirrell alfirrell mentioned this pull request Oct 26, 2020
Closed
@PMassicotte
Copy link
Owner

@eddelbuettel I am not behind a proxy so I can not test it. Any thoughts on this?

@eddelbuettel
Copy link
Collaborator

Same. Can't help for same reason.

@PMassicotte
Copy link
Owner

@alfirrell can you update NEWS.md please

@alfirrell
Copy link
Contributor Author

@alfirrell can you update NEWS.md please

Done.

@PMassicotte PMassicotte merged commit 55f6891 into PMassicotte:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alfirrell @PMassicotte @eddelbuettel