Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forced ordering of responses to prevent them from ending up alphabetical #159

Merged
merged 3 commits into from
May 24, 2023

Conversation

faldor20
Copy link
Contributor

Currently, results in vscode are shown alphabetic which complete is a waste considering nimsuggest goes to the trouble of sorting suggestions.
This sets sortext which tells the client that the server would like the items in a particular order

Copy link
Owner

@PMunch PMunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition, just some minor code fixups and it's all good

src/nimlsp.nim Outdated Show resolved Hide resolved
src/nimlsp.nim Outdated Show resolved Hide resolved
@PMunch PMunch merged commit 1e74138 into PMunch:master May 24, 2023
PMunch added a commit that referenced this pull request May 24, 2023
PMunch added a commit that referenced this pull request May 24, 2023
@PMunch
Copy link
Owner

PMunch commented May 24, 2023

Detected some issues from the Nim CI, apparently you never tried building this? The suggestion variable was used in more than that single location.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants