Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve function dumps #179

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Improve function dumps #179

merged 2 commits into from
Nov 18, 2024

Conversation

felix-dumit
Copy link
Contributor

This PR contains a couple small improvements to function dumps into structure.sql:

  1. Preserve newlines, in case there are multi-line strings inside the function body
  2. Sort functions by name so it's deterministic and behaves like tables

@danielwestendorf
Copy link
Contributor

  1. is related to Reliably sort functions, views, and materialized views in schema #181 (sorted in code instead of SQL when dumping)

@felix-dumit
Copy link
Contributor Author

@danielwestendorf Should I revert those in this PR? or what's the best way forward?

@PNixx PNixx merged commit 41edbf7 into PNixx:master Nov 18, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felix-dumit @danielwestendorf @PNixx