Create config executable #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nachovizzo
reviewed
Mar 8, 2024
Co-authored-by: Ignacio Vizzo <ignaciovizzo@gmail.com>
Co-authored-by: Ignacio Vizzo <ignaciovizzo@gmail.com>
Co-authored-by: Ignacio Vizzo <ignaciovizzo@gmail.com>
True, I like the new one! |
nachovizzo
approved these changes
Mar 9, 2024
tizianoGuadagnino
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new executable
kiss_icp_configwhich will dump aconfig.yamlwith the default parameters wherever you call it. This makes it a lot easier to run the pipeline from the command line and to play around with the parameters without the need to copy the file from the source code or to remember the parameter names .