Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style changes in voxelization and preprocessing utilities #364

Merged
merged 27 commits into from
Jul 22, 2024
Merged

Style changes in voxelization and preprocessing utilities #364

merged 27 commits into from
Jul 22, 2024

Conversation

nachovizzo
Copy link
Collaborator

@nachovizzo nachovizzo commented Jul 11, 2024 •
edited
Loading

Continuation of #362

Style changes on voxelization utilities:

  • Move the voxel downsample function so it belongs to its family (VoxelUtils)
  • minor code style changes in voxelization
  • Remove VoxelHash struct favoring partial template specialization of std::hash so the end user doesn't care what's going on behind the scenes

@nachovizzo nachovizzo mentioned this pull request Jul 11, 2024
Merged
@nachovizzo nachovizzo changed the title Add style changes for a separate PR Style changes in voxelization and preprocessing utilities Jul 12, 2024
@nachovizzo nachovizzo mentioned this pull request Jul 12, 2024
Merged
Base automatically changed from tiziano/merge_voxel_utils to main July 20, 2024 08:23
@nachovizzo nachovizzo marked this pull request as ready for review July 20, 2024 08:38
@nachovizzo
Copy link
Collaborator Author

Now ready to review and 🚢

benemer
benemer approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@benemer benemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged from my side 👍

@tizianoGuadagnino tizianoGuadagnino merged commit 1c28d17 into main Jul 22, 2024
19 checks passed
@tizianoGuadagnino tizianoGuadagnino deleted the tiziano/voxel_utils_style_change branch July 22, 2024 12:42
@nachovizzo nachovizzo added the voxelization All the topic related to voxelization utilities label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benemer benemer benemer approved these changes

@tizianoGuadagnino tizianoGuadagnino tizianoGuadagnino approved these changes

Assignees
No one assigned
Labels
core voxelization All the topic related to voxelization utilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nachovizzo @tizianoGuadagnino @benemer @l00p3