Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PRQL logo icon for .prql file extensions and display in file explorer and editor title bar #39

Closed
RandomFractals opened this issue Feb 3, 2023 · 0 comments · Fixed by #40
Closed

Use PRQL logo icon for .prql file extensions and display in file explorer and editor title bar #39

RandomFractals opened this issue Feb 3, 2023 · 0 comments · Fixed by #40
Assignees
@RandomFractals
Labels
enhancement New feature or request

Comments

@RandomFractals
Copy link
Collaborator

RandomFractals commented Feb 3, 2023 •
edited
Loading

Adding icon config to prql config in package.json contributes/languages will associate all .prql files with PRQL logo.

Added icon config update:

  "contributes": {
    "languages": [
      {
        "id": "prql",
        "aliases": [
          "PRQL",
          "prql"
        ],
        "extensions": [
          ".prql"
        ],
        "configuration": "./language-configuration.json",
        "icon": {
          "dark": "./resources/prql-logo.png",
          "light": "./resources/prql-logo.png"
        }
      }
    ],
...

Resulting PRQL file with icon display:

prql-file-icons
@RandomFractals RandomFractals changed the title Use PRQL logo icon for .prql file extensions and diplay in file explorer and editor title bar Use PRQL logo icon for .prql file extensions and display in file explorer and editor title bar Feb 3, 2023
@RandomFractals RandomFractals mentioned this issue Feb 3, 2023
Merged
max-sixty pushed a commit that referenced this issue Feb 5, 2023
@RandomFractals
Rename Sql Output panel to Sql Preview (#47)
7efa53a 
* use prql logo icon for .prql file ext. in prql language config (#39)

* add Open SQL Output Panel editor title and context menus (#41)

* rename Sql Ouput Panel to SQL Preview

- rename preview command to prql.openSqlPreview
- use vscode open-preview icon in the editor panel title bar for Sql Preview command
- rename sql output panel title to Sql Preview
- rename sql ouput panel id to prql.sqlPreviewPanel
- update Sql Preview info in README.md

Remaining: generate new demo gif with all the recent PRQL iconography and menu options update.
@RandomFractals RandomFractals added the enhancement New feature or request label Feb 8, 2023
@RandomFractals RandomFractals mentioned this issue Feb 9, 2023
Closed
@RandomFractals RandomFractals self-assigned this Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RandomFractals RandomFractals

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add PRQL logo icon to .prql files display in file explorer and PRQL editor title bar
1 participant
@RandomFractals