Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SQL Preview webview implementation #60

Closed
RandomFractals opened this issue Feb 8, 2023 · 0 comments
Closed

Refactor SQL Preview webview implementation #60

RandomFractals opened this issue Feb 8, 2023 · 0 comments
Assignees
Labels
refactor Refactor task

Comments

@RandomFractals
Copy link
Collaborator

RandomFractals commented Feb 8, 2023

  • Create standard src/views folder
  • Move src/sql_output/index.ts to `src/views/sqlPreview.ts
  • Create SqlPreview webview class in sqlPreview.ts instead of using only functions to create that webview panel as we do now

This would make Sql Preview code much more readable, more OOP, and match typical webview setup other vscode extensions use.

See this tableView.ts for an example of a well-designed webview implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor task
Projects
None yet
Development

No branches or pull requests

1 participant