New Sql Preview webview implementation with multi-doc PRQL Sql Preview support #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
RandomFractals
commented
Feb 19, 2023
RandomFractals
commented
- Implement new Sql Preview webview panel class as described in Refactor SQL Preview webview implementation #60
- Add Sql Preview WebviewPanelSerializer to restore Sql Previews on vscode reload (Implement SQL Preview webview deserialize to show it after VSCode reload #102)
- Add multi-doc PRQL SQL Preview support and active PRQL editor/Sql Preview reveal/linking (Create and use separate SQL Preview webview for multiple open PRQL documents #108)
- Refine Sql copy to Clipboard messaging and support of multiple Sql Previews (Display virtual sql filename in clipboard copy notification message #109)
- Rework Sql Preview html template, js and and css
with new ActivePrqlDocumentUri key we'll use to save prql doc. reference to restore sql preview
…nt changes and clear it when sql preview is no longer active, so we can use it for sql preview restore on vscode reload later
and don't clear it for sql preview restore to work on vscode reload
- rename it to sqlPreview.ts - and delete old src/sql_ouput folder
and make extension code imports, multi-line statements, function args, etc. more compact and readable
- rename sql_ouput webview files to sql preivew - add new SqlPreviewSerializer implementation - create new SqlPreview class with most of the setup for multi-instance sql document previews - add view init, refresh and update view state to upated sqlPreview.js
- add open sql preview command to commands - use new SqlPreview.render to render those views
- remove getResourceUri() from src/views/utils.ts - and document html template and resource uri methods
only sql preview uses it
when there is no active prql text editor and sql preview is being restored on vscode reload
- add new command field to all the webview messages - finish wring refresh with storing of document url in view state for the view restore on vscode reload - check if prql file exists prior to loading it in restored sql previews
the other favicon.ico image doesn't get restored for the open sql previews when vscode is reloaded
we now show sql filename instead, so it should be clear it's an sql preview panel.
- add text editor change handler to extension.ts - add SqlPreview.reveal(documentUri) - preserve active editor focus on sql preview reveal - reorg webview html template construction
in sql preview to show it again in webview panel reveal, and use it for active sql preview sql copy to clipboard
when there is no corepsonding open sql preview for a given prql document uri in an active text editor.
and show virtual prql sql document name in copied to clipboard notification
show last valid sql html output even when errors are encountered
and added a note about UI theme neutral html/css in sql preview webview
for more information, see https://pre-commit.ci
|
Damn, this is an impressive list of commits, kudos! |
|
Would have been better to see them in main branch too. Maybe we can do that next time. Most of those changes were new web view implementation related, and I patched some of the questionable display issues and behavior in other parts of extension related to sql preview webview. |
|
But they reached main? Would you want to see them not squashed? |
|
yes. as I mentioned in discord, refactors like this I'd rather see individual commits in main. We should enable that option in this repo Settings for such occasions. |
Done! |
|
Really looking forward to trying this out! |
This was referenced Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.