Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect PRQL based on language ID rather than file extension #25

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Detect PRQL based on language ID rather than file extension #25

merged 1 commit into from
Jan 16, 2023

Conversation

jiripospisil
Copy link
Collaborator

Fixes #24.

@jiripospisil jiripospisil mentioned this pull request Jan 3, 2023
Closed
@max-sixty
Copy link
Member

Looks great to me! Thanks @jiripospisil !

When saving a .prql file, I can confirm it sets the lang to PRQL.

With the proposed code, until the lang is set — either explicitly or with a .prql extension — the output panel won't work — which is probably correct, otherwise it's going to try and parse lots of non-PRQL files.

@max-sixty
Copy link
Member

@jiripospisil I'm going to hit the button if that's OK?

@max-sixty max-sixty merged commit f43c778 into PRQL:main Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support non created file
2 participants
@jiripospisil @max-sixty