Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: Update case syntax to use brackets over braces #3517

Merged
merged 2 commits into from
Sep 17, 2023
Merged

fix!: Update case syntax to use brackets over braces #3517

merged 2 commits into from
Sep 17, 2023

Conversation

AaronMoat
Copy link
Contributor

BREAKING CHANGE: This is a breaking change to case syntax.

Resolves #3462

@eitsupi eitsupi changed the title fix: Update case syntax to use brackets over braces fix!: Update case syntax to use brackets over braces Sep 16, 2023
@eitsupi
Copy link
Member

eitsupi commented Sep 16, 2023

Hi, thanks for working on this!
We can't merge this into the current version (See #3477), so I'll turn it into a draft to prevent merging.

@eitsupi eitsupi marked this pull request as draft September 16, 2023 14:21
eitsupi
eitsupi requested changes Sep 16, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@eitsupi eitsupi added this to the 0.10 milestone Sep 16, 2023
@max-sixty
Copy link
Member

Great work! Thanks @AaronMoat .

Let's merge as soon as we release 0.9.5?

max-sixty
max-sixty reviewed Sep 16, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@max-sixty
Copy link
Member

We can merge now!

@AaronMoat
fix: Update case syntax to use brackets over braces
376188b 
BREAKING CHANGE: This is a breaking change to case syntax.

Resolves #3462
@AaronMoat
Move to a new section in CHANGELOG
7eb9ad8
@AaronMoat AaronMoat marked this pull request as ready for review September 17, 2023 05:41
eitsupi
eitsupi approved these changes Sep 17, 2023
View reviewed changes
Copy link
Member

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AaronMoat AaronMoat mentioned this pull request Sep 17, 2023
Merged
@max-sixty max-sixty merged commit 33b7171 into PRQL:main Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eitsupi eitsupi eitsupi approved these changes

@max-sixty max-sixty Awaiting requested review from max-sixty

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10
Development

Successfully merging this pull request may close these issues.

case should use [] instead of {}
3 participants
@AaronMoat @eitsupi @max-sixty