feat: improve codegen #3737
Merged
feat: improve codegen #3737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-sixty
reviewed
Oct 24, 2023
Comment on lines
+181
to
+192
| fn break_line_within_parenthesis<T: WriteSource>(expr: &T, mut opt: WriteOpt) -> Option<String> { | ||
| let mut r = "(\n".to_string(); | ||
| opt.indent += 1; | ||
| r += &opt.write_indent(); | ||
| opt.reset_line()?; | ||
| r += &expr.write(opt.clone())?; | ||
| r += "\n"; | ||
| opt.indent -= 1; | ||
| r += &opt.write_indent(); | ||
| r += ")"; | ||
| Some(r) | ||
| } |
max-sixty
reviewed
Oct 24, 2023
Comment on lines
+9
to
+11
| group {a.album_id, a.title} (aggregate price = ( | ||
| sum tracks.unit_price | ||
| )) |
There was a problem hiding this comment.
This isn't ideal - it could be fine-tuned so it breaks before aggregate instead of sum.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.