feat: Add display option to compile, allow specifying colors
#4333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eitsupi
reviewed
Sep 20, 2024
Comment on lines
+15
to
+20
| Ok(prql_query) | ||
| .and_then(prqlc_lib::prql_to_pl) | ||
| .and_then(prqlc_lib::pl_to_rq) | ||
| .and_then(|rq| prqlc_lib::rq_to_sql(rq, &options.unwrap_or_default())) | ||
| .map_err(|e| e.composed(&prql_query.into())) | ||
| .map_err(|e| (PyErr::new::<exceptions::PySyntaxError, _>(e.to_string()))) | ||
| .map_err(|e| (PyErr::new::<exceptions::PyValueError, _>(e.to_string()))) |
There was a problem hiding this comment.
Sorry to ask this now, but is the display argument really effective here?
I had trouble getting this option to work when I ported it to prqlc-r (PRQL/prqlc-r#317), but after looking at the source code I realized that this only works within the prql::compile function.
IIUC, this function should be updated to something like:
prqlc_lib::compile(prql_query, &options)
.map_err(|e| PyErr::new::<exceptions::PyValueError, _>(e.to_string())))(Sorry don't have time to try today, but if no one sees this I guess I can take a look in a few days)
There was a problem hiding this comment.
Yes, I'm not sure why I did it that way, I guess I was adjusting from the previous version. Please feel free to simplify!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.