Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(book): Give the book a home page #4495

Merged
merged 5 commits into from
May 21, 2024
Merged

docs(book): Give the book a home page #4495

merged 5 commits into from
May 21, 2024

Conversation

max-sixty
Copy link
Member

Currently it starts on Relations, not sure how that happened or how I hadn't noticed (assuming it's not intentional).

This changes it to start on the Summary page. Previously the Summary text was never shown; only the links that were grabbed and shown on the left bar.

Currently it starts on `Relations`, not sure how that happened or how I hadn't noticed (assuming it's not intentional).

This changes it to start on the Summary page. Previously the Summary text was never shown; only the links that were grabbed and shown on the left bar.
@max-sixty
Copy link
Member Author

max-sixty commented May 21, 2024

i.e. this is the existing home page:

image

The new one isn't great but it's less confusing. Very open to improvements...

(edited since the links didn't seem to work when the summary was used as an index, and worth improved it a bit)

image

@max-sixty max-sixty enabled auto-merge (squash) May 21, 2024 17:01
@max-sixty max-sixty merged commit 5ccb89c into PRQL:main May 21, 2024
35 checks passed
@max-sixty max-sixty deleted the book branch May 21, 2024 20:38
prql-bot pushed a commit that referenced this pull request May 21, 2024
prql-bot added a commit that referenced this pull request May 21, 2024
Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
@richb-hanover
Copy link
Contributor

+1 This "cover page" a significant improvement. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants