Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRQL code blocks are not rendered correctly with Quarto CLI 1.3 (preview) #109

Closed
eitsupi opened this issue Mar 14, 2023 · 5 comments · Fixed by #110
Closed

PRQL code blocks are not rendered correctly with Quarto CLI 1.3 (preview) #109

eitsupi opened this issue Mar 14, 2023 · 5 comments · Fixed by #110
Labels
bug Something isn't working upstream
Milestone

Comments

@eitsupi
Copy link
Member

eitsupi commented Mar 14, 2023

The lang option seems to be ignored.

I think a workaround is to use engine option instead of lang option here.

https://github.com/eitsupi/prqlr/blob/1ed9ca80bdcb20df4247959cd3baf584ba7f6011/R/knitr-engine.R#L22

@eitsupi
Copy link
Member Author

eitsupi commented Mar 14, 2023

I am wondering if I need to add a test to check the rendering results by Quarto.
As Quarto is not an R package and would require an additional step when running on GHA.

There is also the issue of whether the Quarto R package should be added as a dependency......

@cderv
Copy link

cderv commented Mar 14, 2023

Yes you can do that (changing the options$engine) in your engine so that it is picked by Quarto 1.3.

In next version, the lang option will be respected.

@eitsupi
Copy link
Member Author

eitsupi commented Mar 14, 2023

@cderv Thanks for your comment!
Does #110 look good?

@cderv
Copy link

cderv commented Mar 14, 2023

There is also the issue of whether the Quarto R package should be added as a dependency......

IMO you need only to add it (as Suggests) if you want to be thorough while adding a tests for Quarto in testthat while using skip_on_cran() and skip_if_not_installed(), and do snapshot test with markdown output.

Otherwise you could have a specific workflow that do a check without being a tests in R for example and in that case no need to add as a dependency, and no need to run very frequently your test.

By experience, hard to test everything that are output features. We'll check the knitr handling anyway.

@eitsupi
Copy link
Member Author

eitsupi commented Mar 14, 2023

Otherwise you could have a specific workflow that do a check without being a tests in R for example and in that case no need to add as a dependency, and no need to run very frequently your test.

Indeed, this might be more appropriate here.
Since Quarto is updated frequently (thanks!), it seems to make sense to periodically run a test on GHA with installing the binary package prqlr from RSPM or R-universe and check the output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants