Support old Rust on R-universe builder (Rust 1.61 on ubuntu:jammy)
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eitsupi
changed the title
ubuntu:jammy)
eitsupi
commented
Jan 18, 2023
| @@ -10,6 +10,6 @@ name = "prqlr" | |||
| [dependencies] | |||
| extendr-api = { git = "https://github.com/extendr/extendr", rev = "f511254b1be180528a1711e4c87473966a1010d0" } | |||
| # extendr-api = "0.3.1" | |||
| prql-compiler = { git = "https://github.com/PRQL/prql", rev = "1b4217c01c590c51a3e80c8a11b28f78f109a110", default-features = false } | |||
| prql-compiler = { git = "https://github.com/eitsupi/prql", rev = "996a783b56186c3711e065a5b347e6489155085e", default-features = false } | |||
There was a problem hiding this comment.
The commit is on PRQL/prql#1561
Unfortunately, it seems that cargo shipped with Rust 1.61 cannot refer to this commit unless the fork URL is specified.
There was a problem hiding this comment.
I mistakenly thought I could only install from a fork, but that must have been because I had not yet pushed the commit to PR.
Updated by #40
There was a problem hiding this comment.
Hmm, from playing around locally, it seems that Rust 1.61 sometimes installs this and sometimes doesn't, so it still seems basically correct that it can't......
|
It works. Windows builds are failing, but this is obviously a different problem. (r-universe-org/help#219) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix #37 for R-universe.