Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove deprecated cli module and update dependencies #162

Merged
merged 4 commits into from
Mar 28, 2023

Conversation

eitsupi
Copy link
Member

@eitsupi eitsupi commented Mar 28, 2023

Remove the cli module, which has been deprecated since pyprql 0.5.10 (released on PyPI on 2022-12-12) (#93), and update dependencies.

This PR also includes a configuration change for python-semantic-release (major_on_zero = false), making the release after this disruptive change 0.7.0 instead of 1.0.0.

@eitsupi eitsupi requested a review from max-sixty March 28, 2023 12:49
@eitsupi
Copy link
Member Author

eitsupi commented Mar 28, 2023

@max-sixty After this is merged, I would like to publish the new version to PyPI.
(FYI, based on previous experience with the last release, releases via PR did not work and required manual triggering of the workflow.)

@eitsupi
Copy link
Member Author

eitsupi commented Mar 28, 2023

The CLI is very well done and I am impressed, but there are so many dependencies that it will probably need to be split into separate packages if it is to be revived.

@max-sixty max-sixty changed the title refactor!: remove depricaged cli module and update dependencies refactor!: remove deprecated cli module and update dependencies Mar 28, 2023
Copy link
Member

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

It was a wonderful project, it remains in the soul of PRQL even if not the repo...

@max-sixty
Copy link
Member

Shall I release 0.7.0 from the main repo? It's slightly simpler of the versions stay aligned, unless we have a reason to deviate

@eitsupi
Copy link
Member Author

eitsupi commented Mar 28, 2023

Shall I release 0.7.0 from the main repo? It's slightly simpler of the versions stay aligned, unless we have a reason to deviate

If that is your intention, I am happy to hold off on releasing pyprql.
(I just thought it was worth releasing because of the many additional features related to IPython magic.)

@eitsupi eitsupi merged commit 89e1199 into PRQL:main Mar 28, 2023
@eitsupi eitsupi deleted the remove-cli branch March 28, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants