Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix GitHub Actions workflows and more python versions support #164

Merged
merged 5 commits into from
Apr 2, 2023

Conversation

eitsupi
Copy link
Member

@eitsupi eitsupi commented Apr 2, 2023

I noticed that the checks by CI were not actually using the Python version of the matrix, so I'm fixing that.

I'm also fixing other errors discovered using actionlint and remove nonworking codecov step.

@eitsupi eitsupi changed the title ci: fix check GitHub Actions workflow ci: fix GitHub Actions workflows Apr 2, 2023
@eitsupi eitsupi changed the title ci: fix GitHub Actions workflows fix: fix GitHub Actions workflows and more python versions support Apr 2, 2023
@eitsupi
Copy link
Member Author

eitsupi commented Apr 2, 2023

@max-sixty codecov step does not seem working now.
I don't think this has been working for a while so if it is not of high importance I would like to remove it for now, is that ok?

@max-sixty
Copy link
Member

For sure, thanks for fixing

@eitsupi eitsupi marked this pull request as ready for review April 2, 2023 02:51
@eitsupi
Copy link
Member Author

eitsupi commented Apr 2, 2023

Thanks for taking a look at this.
I will merge and go ahead.

@eitsupi eitsupi merged commit 0901392 into PRQL:main Apr 2, 2023
@eitsupi eitsupi deleted the fix-ci branch April 2, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants