Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opening license url in browser instead of webview on Android 5.x #45

Closed
yuly-vertkin opened this issue Jul 16, 2015 · 1 comment · Fixed by #50
Closed

Opening license url in browser instead of webview on Android 5.x #45

yuly-vertkin opened this issue Jul 16, 2015 · 1 comment · Fixed by #50
Labels
bug pull-request-wanted

Comments

@yuly-vertkin
Copy link

On Android 4.x license url opens in browser window but on Android 5.x in the license window. "Close" button closes window with all licenses so it needed to open it again. Could you please repair it.
@samskiter
Copy link
Contributor

Also seeing this, looks like a bug in WebView/WebViewClient

hameno added a commit that referenced this issue Sep 11, 2015
@hameno
Open webview links in external browser
43dd792 
- fixes #45
@hameno hameno mentioned this issue Sep 11, 2015
Merged
hameno added a commit that referenced this issue Jan 5, 2016
@hameno
Open webview links in external browser
6e3115b 
- fixes #45
- fixed for native dialog
@hameno hameno changed the title Openning license url in browser instead of webview on Android 5.x Opening license url in browser instead of webview on Android 5.x Apr 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug pull-request-wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Open webview links in external browser PSDev/LicensesDialog
3 participants
@hameno @samskiter @yuly-vertkin