Fixed a little thing in licenses text loading and added some methods for customization

[barondem]

Fixed missing space in while construct during licenses text loading (I don't think it's done that way on purpose) and added three methods to customize the dialog theme and title divider with some tricks found on the Web.

[hameno]

I think you are missing the show() call here

[barondem]

You're right. Fixed.

[hameno]

Could you please also implement this for the Fragment?

[barondem]

I already thought to this and I'll try to do this; if it works, I'll commit it too.

[barondem]

OK, it works with dialogfragment; maybe you'd like to check the code...
Anyway, I'd like to ask you a few things: is there a precise reason because of which you didn't include any parameters for custom title and close button in the dialogfragment newInstance methods?
What about a dedicate version for who wants to develop only for API level 14+ for example (i.e. a version which uses FragmentManager from framework and not from support library), because at the moment the dialogfragment can't be used if the activity isn't extending fragmentactivity or actionbaractivity.

[hameno]

Please remove the line break

[barondem]

Done.

[hameno]

is there a precise reason because of which you didn't include any parameters for custom title and close button in the dialogfragment newInstance methods?

Yes, because you can simply override those inside your resources.

What about a dedicate version for who wants to develop only for API level 14+ for example (i.e. a version which uses FragmentManager from framework and not from support library), because at the moment the dialogfragment can't be used if the activity isn't extending fragmentactivity or actionbaractivity.

Maybe, but I'm still only using the FragmentActivitys. IMHO to have consistent behavior through all platform versions you should always use the Fragments from the support library.

[hameno]

Okay, just one little thing left: could you please squash all the commits into one? (see http://rebaseandsqua.sh/ for more info)

[barondem]

Tried that script bit it says no local chance to save... Could it be an idea to do a new pull request?

[hameno]

No, try this http://davidwalsh.name/squash-commits-git

[barondem]

I couldn't manage to squash the commits like you suggested, so I rolled back to your last commit and made only one commit; maybe it's not the most straightforward way, but I think it should work.

[barondem]

Just a few other questions:

1. Can you tell me the part of code (or the xml file) which makes the dialog title and button have a light gray background? I think it's not the default style because if I create and show a common dialog it just has a plain white background also on title and button
2. If I'd need to create a custom version of this to use framework dialog (and framework fragment manager), I should also remove/alter your code about on dismiss listener; is it all strictly necerssary? Should it be safe to remove some setOnDismissListener call?

[hameno]

1. There is no code which handles this. It is all androids default style. I depends on the targeted api version.
2. The only difference should be with the imports.

[barondem]

1. OK, though I'm not sure about this, since I tried to change target and compile API version without any visual change; maybe I'll investigate more deeply
2. I also thought this but this code causes an exception and a crash with framework dialog:
   dialog.setOnDismissListener(new DialogInterface.OnDismissListener() {
   @OverRide
   public void onDismiss(final DialogInterface dialog) {
   if (mOnDismissListener != null) {
   mOnDismissListener.onDismiss(dialog);
   }
   }
   });
   So, I modified this by deleting it from its position, implementing the interface in the outer class and overriding the method there with your code; I didn't find any drawback for now. What do you think about it?

[hameno]

2. What was the exception?

Regarding you latest commit: I don't like the massive code duplications. Please improve this by reusing more code (like with show and createAndShow -> should be create().show()). Also please use delegating constructors to remove duplication.

[barondem]

First, sorry for the late response; second, it was an IllegalStateException( "You can not set Dialog's OnCancelListener or OnDismissListener"); third, I'll try to optimize the code, where possible...

[barondem]

Optimization done: source code is now 48 lines lighter, if I'm not wrong; I used delegating constructors like you recommended and I also fixed some really ugly bug (my fault, honestly) in show() and createAndShow() methods. Shall I commit?

[hameno]

Sure, let me see it.

[barondem]

Pushed commit.

[hameno]

I have reviewed your changes. I've made some changes to replace the excess of constructors with a builder class. Can you please checkout https://github.com/PSDev/LicensesDialog/tree/pr/30 and report back if your theme handling still works? Also it would be great if you could rebase this pull-request onto this branch and add a sample to the sample module.

[barondem]

Looks good; just a thing: in the Builder class I think the method should be setDividerColor(final int dividerColor) as well as the local variable should be mDividerColor since the passed argument is assumed to be actually the color value, not its I'd (and I don't see anywhere a line of code which does int dividerColor = getResources.getColor(mDividerColorId);). Hence if a developer passes a color id I think it wouldn't work and it would be really sad. So, I think you should either change those names or retrieve the color somewhere in the code (or even better create an overload to allow both the usages).

[barondem]

Tried and in fact it doesn't work with a color id. Oh, and in LicensesDialogFragment's onCreateDialog it should be .show(), not .create() (last line); the divider color isn't set otherwise.

[barondem]

Any news about this pull request?

[hameno]

Sorry, I have been very busy. I'll try to take a look at it soon.

[barondem]

OK, if you want I could commit the necessary fixes in the meantime.

[barondem]

I added custom theme samples and proposed fixes and additions for some things and committed and made a pull request on the pr/30 branch, as you asked. It should be quite good now, I think.
Oh, I saw custom themes don't work on gingerbread (with touchwiz, to say the truth), maybe the trick I used isn't supported there. Though, it doesn't crash, at least, and works really good on newer platforms.

[hameno]

I merged your PR to my branch - will take a final look at it soon and hopefully do the release this week.

[hameno]

Manually merged