Using System.getProperty("line.separator") instead of '\n' and adding pre-caching of licenses text

[ngdelamo]

In some Android versions using '\n' does not lead to a new line on TextViews. Instead, the standard System.getProperty("line.separator") must be used. This was affecting licenses text, since the method for reading them was adding '\n' characters that were not being shown in the licenses dialog (see the following image from a screenshot on a Nexus 5 running Android 4.4.4)

Also, when a license's text was requested, either by using 'getSummaryText' or 'getFullText', a fresh new read from the raw resource was performed. This can slow down the dialog when multiple instances of the same license are used, which is quite common (most licenses on our projects are apache 2.0). I added some changes to read the raw resource once and store the resulting String, so subsequent calls to the previous methods would return the cached String.

[hameno]

Make that a constant

[hameno]

Thank you for your contribution. Could you please take a look at my comments and fix them? Also, I feel like the caching mechanism produces a lot of duplicate code, maybe you could move it to the base class?

[ngdelamo]

Sure, I'll add the changes. I was not sure about adding the cached Strings to the License class in case you wanted to keep it implementation-independent. But if you don't mind, I'll try to pull the cache code to the parent License class

[hameno]

That would be better I think :)

[ngdelamo]

Done. Could you review my changes? I had to rename some methods in the license subclasses in order to maintain compatibility with the previously existing ones in the License base class.

[hameno]

Done, just three little things and then it's good to go.

[ngdelamo]

Good, that was a pretty fast PR :)

[hameno]

Yep, holiday here ;)