feat: add auto_finish to FrameEncoder #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #95 +/- ##
==========================================
- Coverage 90.14% 89.39% -0.75%
==========================================
Files 11 11
Lines 2161 2179 +18
==========================================
Hits 1948 1948
- Misses 213 231 +18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
l4l
reviewed
May 18, 2023
| fn drop(&mut self) { | ||
| if let Some(mut encoder) = self.encoder.take() { | ||
| if let Err(err) = encoder.try_finish() { | ||
| panic!("Error when flushing frame on drop {:?} ", err); |
There was a problem hiding this comment.
This will trigger abort if the thread is already panicking.
There was a problem hiding this comment.
That is already covered by a PR here: #100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94