-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix types #282
Merged
Merged
Fix types #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stack from ghstack (oldest at bottom): |
This was referenced May 12, 2024
Merged
Merged
ckolbPTB
requested changes
May 17, 2024
ckolbPTB
approved these changes
May 24, 2024
fzimmermann89
added a commit
that referenced
this pull request
Nov 10, 2024
This fixes all typing issues in tests and some other inconsistencies. - Make the KData mixins return a Self (i.e. KData). So, for example, KData.remove_oversampling will now result in KData (used to be Any) - Fix issues caused by using numpy in the rotation tests. Widen allowed types in Rotation from only tensor inputs to also allow nested sequences of floats. - Add type ignores for paths that can never be reached according to the type hints but are tested anyways - Allow a single int as size for RandomGenerator - Make return_sensitivity in Rotation.align_vectors a keyword-only argument, and overload the return type conditional on its value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes all type issues in tests and some other inconsistencies.
DO NOT CLICK THE MERGE BUTTON without considering the order of merges according to the stack..