Add JustPIC compatibility
#237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albert-de-montserrat
requested changes
Sep 20, 2024
albert-de-montserrat
requested changes
Sep 24, 2024
Co-authored-by: Albert de Montserrat <albert.de.montserrat@gmail.com>
albert-de-montserrat
added a commit
that referenced
this pull request
Sep 24, 2024
This reverts commit 062f4bf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the recent changes made in
JustPIC.jland removes thePhaseRatiocalculation fromJustRelax.Project.tomlmemory.register()EDIT: PhaseRatios error is fixed in JustPIC, new version must first be released
EDIT2: JustPIC has now been released. Dropping CI for 1.9, adding Buildkite for
1.11