Switching data providers to static #1061
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garak
requested changes
Aug 4, 2023
| @@ -39,3 +39,5 @@ clover.xml | |||
| ###> custom ### | |||
| .stylelintcache | |||
| ###< custom ### | |||
|
|
|||
There was a problem hiding this comment.
Please revert this change.
Specific files/dirs to ignore should be placed in a global .gitignore file, not a project one.
| ['0.1.0-alpha1', 'alpha'], | ||
| ['0.1.0-alpha', 'alpha'], | ||
| ]; | ||
| yield ['1.0.0', 'stable']; |
There was a problem hiding this comment.
I don't see much benefit in converting this to a Generator.
There's not performance gain, since PHPUnit needs to get all values in advance
|
any news? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #978 from @garak