Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accel calibration garbage mavlink output on completion #14829

Closed
dagar opened this issue May 4, 2020 · 5 comments · Fixed by #15235
Closed

accel calibration garbage mavlink output on completion #14829

dagar opened this issue May 4, 2020 · 5 comments · Fixed by #15235
Assignees
@dagar
Labels
bug

Comments

@dagar
Copy link
Member

dagar commented May 4, 2020

Screenshot from 2020-05-04 19-07-43
@dagar dagar added the bug label May 4, 2020
@dagar dagar self-assigned this May 4, 2020
@MaEtUgR
Copy link
Member

MaEtUgR commented May 5, 2020

I've seen this output before but only much later than the calibration so I didn't know where they were coming from. But now it makes sense I recalibrated some time before seeing them so I can confirm. 👍

@stale stale bot added the stale label Aug 3, 2020
@PX4 PX4 deleted a comment from stale bot Aug 3, 2020
@stale stale bot removed the stale label Aug 3, 2020
@MaEtUgR
Copy link
Member

MaEtUgR commented Aug 19, 2020

Looks like QGC is handling the messages reported with https://github.com/PX4/Firmware/blob/7b4ae7c6586bcf355beda3741850a0b2c8532cb4/src/modules/commander/accelerometer_calibration.cpp#L335 but for some reason the end gets put out to the user. Line number will change after #15235 but presumably it's still there.

@dagar
Copy link
Member Author

dagar commented Aug 19, 2020 •
edited
Loading

Oh! It's simply the message spilling over. Thanks @MaEtUgR

QGC has "special" (hacks) handling to hide the [cal] prefixed messages, but not the next line if its split.

@MaEtUgR
Copy link
Member

MaEtUgR commented Aug 19, 2020 •
edited
Loading

Ah right and before the line splitting it just got cut so no one saw it 💡

@dagar
Copy link
Member Author

dagar commented Aug 19, 2020

Fixed in #15235.

6072d7d

@dagar dagar mentioned this issue Aug 19, 2020
Merged
dagar added a commit that referenced this issue Aug 19, 2020
@dagar
commander: accel calibration reduce status length
c94ced3 
 - this keeps the string within a single Mavlink STATUSTEXT
 - fixes #14829
dagar added a commit that referenced this issue Aug 20, 2020
@dagar
commander: accel calibration reduce status length
a4cf1a7 
 - this keeps the string within a single Mavlink STATUSTEXT
 - fixes #14829
dagar added a commit that referenced this issue Aug 20, 2020
@dagar
commander: accel calibration reduce status length
f38b10e 
 - this keeps the string within a single Mavlink STATUSTEXT
 - fixes #14829
dagar added a commit that referenced this issue Aug 21, 2020
@dagar
commander: accel calibration reduce status length
5242160 
 - this keeps the string within a single Mavlink STATUSTEXT
 - fixes #14829
Hoeze pushed a commit to FSRH/Firmware that referenced this issue Sep 20, 2020
@dagar @Hoeze
commander: accel calibration reduce status length
501c65a 
 - this keeps the string within a single Mavlink STATUSTEXT
 - fixes PX4#14829
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dagar dagar

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

accumulated calibration fixes and improvements (mostly magnetometer) PX4/PX4-Autopilot
2 participants
@dagar @MaEtUgR