MAVLink Simulation: Battery Percentage Fix #11205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 3e6e1f5 the simulated battery percentage was reversed. I'm assuming because of the possibly missleading variable name. Now I'm fixing it by switching the maximum and minimum voltage such that the name is not misleading anymore but it still works as expected.
In 5bb9bab I made MAVLink send a rounded up integer instead of rounded down. This makes sense in practice because the low battery reactions happen exactly when the reported number switches in the UI. But here we want to provoke an exact 50% in the UI so we stop counting at 49.9%, it get's rounded up and we see the expected result.
MaEtUgR
force-pushed
the
simulation-battery-fix
branch
from
17e5e31
to
d3a0311
Compare
LorenzMeier
approved these changes
Jan 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's all in the commit messages:
In 3e6e1f5 (Make SITL tests faster than real-time #10648) the simulated battery
percentage was reversed. I'm assuming because of the possibly
missleading variable name. Now I'm fixing it by switching the
maximum and minimum voltage such that the name is not misleading anymore
but it still works as expected.
In 5bb9bab (Mavlink: round battery percentage up instead of down #8986) I made MAVLink send a
rounded up integer instead of rounded down. This makes sense in practice
because the low battery reactions happen exactly when the reported number
switches in the UI. But here we want to provoke an exact 50% in the UI so
we stop counting at 49.9%, it get's rounded up and we see the expected
result.