Fix rcS crash caused by floating point arithmetic to enable slower than real-time simulation #12401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried to fix this too a couple of days ago and I failed against the shell checker: It looks like your solution works, thanks a lot! |
julianoes
approved these changes
Jul 3, 2019
This was referenced Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #12400 where floating point lockstep realtime speed factors such as
PX4_SIM_SPEED_FACTOR=0.5would cause thercSscript to crash. This PR allows floating point (and therefore slower than real-time) lockstep simulation.Preferred solution: use
bcinstead of built-in shell math to support both integer and floating point arithmetic.An extensive list of possible alternative solutions can be found here: https://unix.stackexchange.com/a/40787.