-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
microRTPS: add timesync #14297
Merged
Merged
microRTPS: add timesync #14297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhkabir
reviewed
Mar 4, 2020
jkflying
reviewed
Mar 5, 2020
TSC21
force-pushed
the
feature/add_rtps_timesync
branch
3 times, most recently
from
March 9, 2020 13:55
a79e2e2
to
fe1a18b
Compare
… for the same entity)
TSC21
force-pushed
the
feature/add_rtps_timesync
branch
from
March 9, 2020 13:59
fe1a18b
to
a61b7fe
Compare
jkflying
requested changes
Mar 9, 2020
TSC21
force-pushed
the
feature/add_rtps_timesync
branch
from
March 9, 2020 14:38
af9a154
to
ff4af95
Compare
TSC21
force-pushed
the
feature/add_rtps_timesync
branch
from
March 9, 2020 14:49
0ac4a7f
to
f9e0d8f
Compare
jkflying
approved these changes
Mar 9, 2020
jkflying
requested changes
Mar 9, 2020
TSC21
force-pushed
the
feature/add_rtps_timesync
branch
from
March 9, 2020 19:57
b29df5c
to
2e85345
Compare
jkflying
previously approved these changes
Mar 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one more small cleanup, and I'm good.
TSC21
force-pushed
the
feature/add_rtps_timesync
branch
from
March 10, 2020 11:48
cee648b
to
af9cdcd
Compare
jkflying
approved these changes
Mar 10, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds timesync for the microRTPS bridge. The agent is the one responsible to initiate the time sync hand shake and compute the offset. The client, at this stage, just responds to the msgs. Eventually in the future the timesync being done on the Mavlink module will be generalised to be used also on the microRTPS client, but not need to do it right now.