change mavlink_log from critical to info for battery state #14377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…BATTERY_WARNING_CRITICAL states. BATTERY_WARNING_EMERGENCY stays the same for now.
bkueng
reviewed
Mar 13, 2020
|
The main reason is that we don't want it to show up as a warning in the log file. I guess we can wait for proper UI to be implemented on the QGC side before getting it in. |
…rgency When this happens very likely the user had a crash so we should flag it as an error and not just warning.
|
@DanielePettenuzzo can yoi rebase? |
|
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
|
I'm closing this as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only for BATTERY_WARNING_LOW and BATTERY_WARNING_CRITICAL states. BATTERY_WARNING_EMERGENCY stays the same for now since we don't have any better way of showing this in QGC.