[DO NOT MERGE] CI test for UAVCAN SensorBridge Improvements #14424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UavcanGnssBridge did not support more than 1 GNSS callback/publisher. This has now been fixed; it works the same as the baro, mag, and flow sensor bridges. The EKF2 still doesn't support more than 2 GPS publishers, however.
Can now see proper UAVCAN bus and unique device ID for barometer instances; optical flow will also have the UAVCAN node ID assigned as sensor ID.
Supposedly multiple sensor callbacks were supported; in reality, this was not the case, and additionally what is there is not well implemented. This work is still WIP but appears to allow calibration of multiple compasses connected via UAVCAN.
For print_status() purposes only.
+ Fixed baro bridge's use of /dev/baro for driver registration; named it /dev/uavcan/baro instead + Other cleanup
Use absolute-zero constant instead of 273.15f Co-Authored-By: Daniel Agar <daniel@agar.ca>
Also add new 'generic' device types for UAVCAN sensors
Style changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by this pull request
Just trying to run CI with a rebased version of #14345
Describe possible alternatives
I tried just creating a branch prepending
pr-but it only runs two tests and seems to try and fetch the branch that was pushed before the one it should be testing...