Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logger: fix hardfault for invalid SDLOG_PROFILE setting #15236

Merged
merged 2 commits into from
Jun 29, 2020

Conversation

bkueng
Copy link
Member

@bkueng bkueng commented Jun 29, 2020

If some bits are set but no topic was added, _subscriptions was null but
later accessed.

During normal use this only happens when switching between different
firmware versions with different SDLOG_PROFILE definition (with custom
config).

Also: param: also show unused params for 'param show -c' (I find this generally useful for debugging).

bkueng added 2 commits June 29, 2020 10:22
If some bits are set but no topic was added, _subscriptions was null but
later accessed.

During normal use this only happens when switching between different
firmware versions with different SDLOG_PROFILE definition (with custom
config).
I find this generally useful for debugging.
Copy link
Member

@bresch bresch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me, thanks!

@dagar dagar merged commit 0c4fd2b into master Jun 29, 2020
@dagar dagar deleted the logger_fix_hardfault branch June 29, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants