Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raname DJI Airframe name to prevent Large PWM_MIN for normal ESCs #15243

Merged
merged 1 commit into from
Jul 3, 2020

Conversation

bys1123
Copy link
Contributor

@bys1123 bys1123 commented Jun 30, 2020

I saw too many users choose DJI Airframe for their normal ESCs, makes lots of trouble, even hit the ceiling.
So, this change could provent most of these situation.

@bys1123
Copy link
Contributor Author

bys1123 commented Jun 30, 2020

60%+ beginners will choose DJI Airframe for whatever frame they are using without this description. (Even including me at the very beginning, for my F450 airframe with normal ESCs, and almost hit my ceiling lamp at first test)

@dagar dagar requested a review from MaEtUgR June 30, 2020 13:27
Copy link
Member

@bresch bresch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@dannyfpv69
Copy link

i tested on pixhawk1 v2
the dji escs on the f-450 airframe

20200701_203004

Screen Shot 2020-07-01 at 8 26 23 PM

I raised the value PWM_MIN to 1230 us for it to work properly

@bys1123
Copy link
Contributor Author

bys1123 commented Jul 2, 2020

@dannyfpv69 You can choose the DJI F450 Airframe in QGC airframe setting, it will auto set the PWM_MIN and PIDs.

@bresch bresch merged commit 400c44b into PX4:master Jul 3, 2020
@MaEtUgR MaEtUgR changed the title Raname DJI Airframe name to Provent Large PWM_MIN for normal ESCs Raname DJI Airframe name to prevent Large PWM_MIN for normal ESCs Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants