Setup scripts improvements (no more Java 8) #15334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagar
reviewed
Jul 15, 2020
MaEtUgR
reviewed
Jul 15, 2020
julianoes
force-pushed
the
pr-improve-setup
branch
from
e3614d5
to
35d664c
Compare
|
Looks good to me, except the macos build failed due to missing ccache. And of course I don't have merge rights. |
What? It should not fail without ccache. ccache is completely optional. |
|
Don't shoot the messenger - shoot CI |
|
@hamishwillee sorry, let me check :) |
|
@hamishwillee it will come here: PX4/homebrew-px4#58 |
- Spaces -> tabs. - Remove "brew install python" because it's already a dependency of the px4-dev tap. - Remove "brew install ccache" as we can also add it to the px4-dev tap. - Don't try to update pip installation, it works fine as is. - Install pip dependencies as user, no need for system-wide install.
Ubuntu was already unsupported, now that 20.04 is out, however, the change was not reflected yet in this script.
However, Java 11 or 14 depending on the Ubuntu version are just fine.
It's called macOS for a while now, and no longer OSX.
julianoes
force-pushed
the
pr-improve-setup
branch
from
35d664c
to
f5100d7
Compare
|
I'd say let's merge this. |
dagar
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the setup scripts quite a bit, mostly because we no longer require Java 8 (since PX4/jMAVSim#119). For the rest of the change, check the commits please.