Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly set the FW_ARSP_MODE parameter value #15394

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Correctly set the FW_ARSP_MODE parameter value #15394

merged 1 commit into from
Jul 22, 2020

Conversation

xdwgood
Copy link
Contributor

@xdwgood xdwgood commented Jul 22, 2020

/**
 * Airspeed mode
 *
 * For small wings or VTOL without airspeed sensor this parameter can be used to
 * enable flying without an airspeed reading
 *
 * @value 0 Normal (use airspeed if available)
 * @value 1 Airspeed disabled
 * @group FW Attitude Control
 */
PARAM_DEFINE_INT32(FW_ARSP_MODE, 0);

not have value 2

By the way, I think the functions of these two parameters are similar CBRK_AIRSPD_CHK FW_ARSP_MODE

Can we just keep CBRK_AIRSPD_CHK? Use CBRK_AIRSPD_CHK instead of FW_ARSP_MODE

FYI @sfuhrer

@dagar
Copy link
Member

dagar commented Jul 22, 2020

At one point it had multiple values.

Screenshot from 2020-07-22 10-37-10

Currently CBRK_AIRSPD_CHK is a state machine level check that allows preflight to not require airspeed. It's also an optimization in rc.sensors that will skip trying to probe and start the differential pressure sensor drivers.

FW_ARSP_MODE is a controller level configuration parameter (fw_att_control, fw_pos_control_l1) that allows them to optionally operate without airspeed.

If anything I think I'd want to get rid of the circuit breaker parameter. Then things like the controllers could tie into the state machine with requirements and health. If something in the system requires airspeed then it can be locked into the preflight check system. If nothing in the system requires airspeed, then commander doesn't need to care.

@dagar dagar added bug Hybrid VTOL 🛩️🚁 Multirotor + Fixedwing! labels Jul 22, 2020
@dagar dagar merged commit f014d0d into PX4:master Jul 22, 2020
@xdwgood xdwgood deleted the master branch July 22, 2020 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Hybrid VTOL 🛩️🚁 Multirotor + Fixedwing!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants