Tools: abort SITL start if gzserver fails #15399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes gzserver seems to not start or not start fast enough. In this case, instead of stalling forever, it would be nice to abort.
dagar
reviewed
Jul 22, 2020
|
|
||
| if gz model --spawn-file="${src_path}/Tools/sitl_gazebo/models/${model}/${model}.sdf" --model-name=${model} -x 1.01 -y 0.98 -z 0.83 2>&1 | grep "An instance of Gazebo is not running."; then |
There was a problem hiding this comment.
What's up with the magic coordinates? -x 1.01 -y 0.98 -z 0.83?
There was a problem hiding this comment.
@dagar That was something I added a while ago to spawn the vehicle somewhere that is not zero, and was specified in the world file previously.
There was a problem hiding this comment.
@Jaeyoung-Lim Remember I asked the same question (see note below)? Perhaps worth an in-source comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes gzserver seems to not start or not start fast enough. In this case, instead of stalling forever, it would be nice to abort.
Closes #15398.