Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for INA228 #17994

Merged
merged 7 commits into from
Aug 22, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions boards/px4/fmu-v5x/default.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ px4_add_board(
pca9685
pca9685_pwm_out
power_monitor/ina226
power_monitor/ina228
#protocol_splitter
pwm_input
pwm_out_sim
Expand Down
3 changes: 3 additions & 0 deletions boards/px4/fmu-v5x/init/rc.board_defaults
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,7 @@
# board specific defaults
#------------------------------------------------------------------------------

param set-default SENS_EN_INA228 0
param set-default SENS_EN_INA226 1

safety_button start
17 changes: 14 additions & 3 deletions boards/px4/fmu-v5x/init/rc.board_sensors
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,20 @@
#------------------------------------------------------------------------------
board_adc start

# Start Digital power monitors
ina226 -X -b 1 -t 1 -k start
ina226 -X -b 2 -t 2 -k start

if param compare SENS_EN_INA226 1
then
# Start Digital power monitors
ina226 -X -b 1 -t 1 -k start
ina226 -X -b 2 -t 2 -k start
fi

if param compare SENS_EN_INA228 1
then
# Start Digital power monitors
ina228 -X -b 1 -t 1 -k start
ina228 -X -b 2 -t 2 -k start
fi

if ver hwtypecmp V5X90 V5X91 V5X92 V5Xa0 V5Xa1 V5Xa2
then
Expand Down
3 changes: 2 additions & 1 deletion boards/px4/fmu-v6x/default.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ px4_add_board(
pca9685
pca9685_pwm_out
power_monitor/ina226
power_monitor/ina228
#protocol_splitter
pwm_out_sim
pwm_out
Expand All @@ -49,7 +50,7 @@ px4_add_board(
roboclaw
rpm
safety_button
smart_battery/batmon
#smart_battery/batmon
telemetry # all available telemetry drivers
tone_alarm
uavcan
Expand Down
5 changes: 4 additions & 1 deletion boards/px4/fmu-v6x/init/rc.board_defaults
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,7 @@
# board specific defaults
#------------------------------------------------------------------------------

safety_button start
param set-default SENS_EN_INA228 0
param set-default SENS_EN_INA226 1

safety_button start
16 changes: 13 additions & 3 deletions boards/px4/fmu-v6x/init/rc.board_sensors
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,19 @@
#------------------------------------------------------------------------------
board_adc start

# Start Digital power monitors
ina226 -X -b 1 -t 1 -k start
ina226 -X -b 2 -t 2 -k start
if param compare SENS_EN_INA226 1
then
# Start Digital power monitors
ina226 -X -b 1 -t 1 -k start
ina226 -X -b 2 -t 2 -k start
fi

if param compare SENS_EN_INA228 1
then
# Start Digital power monitors
ina228 -X -b 1 -t 1 -k start
ina228 -X -b 2 -t 2 -k start
fi

# Internal SPI BMI088
bmi088 -A -R 4 -s start
Expand Down
3 changes: 2 additions & 1 deletion src/drivers/drv_sensor.h
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,8 @@
#define DRV_DIST_DEVTYPE_TERARANGER 0x75
#define DRV_DIST_DEVTYPE_VL53L0X 0x76
#define DRV_POWER_DEVTYPE_INA226 0x77
#define DRV_POWER_DEVTYPE_VOXLPM 0x78
#define DRV_POWER_DEVTYPE_INA228 0x78
#define DRV_POWER_DEVTYPE_VOXLPM 0x79

#define DRV_LED_DEVTYPE_RGBLED 0x7a
#define DRV_LED_DEVTYPE_RGBLED_NCP5623C 0x7b
Expand Down
12 changes: 11 additions & 1 deletion src/drivers/power_monitor/ina226/ina226_params.c
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/****************************************************************************
*
* Copyright (c) 2019 PX4 Development Team. All rights reserved.
* Copyright (c) 2019, 2021 PX4 Development Team. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
Expand Down Expand Up @@ -31,6 +31,16 @@
*
****************************************************************************/

/**
* Enable INA226 Power Monitor
*
* For systems a INA226 Power Monitor, this should be set to true
*
* @group Sensors
* @boolean
* @reboot_required true
*/
PARAM_DEFINE_INT32(SENS_EN_INA226, 0);

/**
* INA226 Power Monitor Config
Expand Down
44 changes: 44 additions & 0 deletions src/drivers/power_monitor/ina228/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
############################################################################
#
# Copyright (c) 2021 PX4 Development Team. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
# are met:
#
# 1. Redistributions of source code must retain the above copyright
# notice, this list of conditions and the following disclaimer.
# 2. Redistributions in binary form must reproduce the above copyright
# notice, this list of conditions and the following disclaimer in
# the documentation and/or other materials provided with the
# distribution.
# 3. Neither the name PX4 nor the names of its contributors may be
# used to endorse or promote products derived from this software
# without specific prior written permission.
#
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
# FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
# COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
# INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
# BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
# OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
# AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
# LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
# ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
# POSSIBILITY OF SUCH DAMAGE.
#
############################################################################
px4_add_module(
MODULE drivers__ina228
MAIN ina228
COMPILE_FLAGS
-Wno-cast-align # TODO: fix and enable
SRCS
ina228_main.cpp
ina228.cpp
DEPENDS
battery
px4_work_queue
)
Loading