Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sensors: always start baro/GPS/mag aggregators if SYS_HAS_* set #18113

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

dagar
Copy link
Member

@dagar dagar commented Aug 20, 2021

@lukegluke can you give this a try?

@lukegluke
Copy link
Contributor

Thanks, it fix the issue, no param sync issue depending on gps state now.
But just to notice, I've tested not with recent master (somewhere before v1.12.0-beta1) and haven't tested preflight logic, but looks ok.

@dagar
Copy link
Member Author

dagar commented Aug 20, 2021

But just to notice, I've tested not with recent master (somewhere before v1.12.0-beta1) and haven't tested preflight logic, but looks ok.

Thanks, that's worth pointing out. I didn't like the GPS was being marked present and healthy initially regardless of actual status.

@dagar dagar merged commit 61702d0 into master Aug 23, 2021
@dagar dagar deleted the pr-sensors_sys_has_gps branch August 23, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Several SENS_* params could be not marked as used on start
2 participants