Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] px4io_serial: ensure TX DMA is stopped if exiting early on stream error #18172

Merged
merged 1 commit into from
Aug 31, 2021
Merged

[WIP] px4io_serial: ensure TX DMA is stopped if exiting early on stream error #18172

merged 1 commit into from
Aug 31, 2021

Conversation

dagar
Copy link
Member

@dagar dagar commented Aug 31, 2021

  • otherwise the next retry can happen quickly enough that dma setup hangs waiting for the stream
  • this failure happens consistently if ardupilot is still on the px4io (eg cubeorange)

@dagar
px4io_serial: ensure TX DMA is stopped if exiting early on stream error
e11d04c 
 - otherwise the next retry can happen quickly enough that dma setup
hangs waiting for the stream
@dagar dagar added the bug label Aug 31, 2021
@dagar dagar requested a review from davids5 August 31, 2021 01:03
@taileron
Copy link
Contributor

i was hoping part of the x2.1-777 uart dma problem could be solved with this too, unfortunately everything on uart dma still needs to be disabled for the IO flash process to succeed ...

davids5
davids5 reviewed Aug 31, 2021
View reviewed changes
Copy link
Member

@davids5 davids5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we tell what the cause of the stream error is?

@davids5 davids5 marked this pull request as ready for review August 31, 2021 20:56
@davids5
Copy link
Member

davids5 commented Aug 31, 2021

Regardless of the root cause this can only help.

@davids5 davids5 self-requested a review August 31, 2021 20:59
davids5
davids5 approved these changes Aug 31, 2021
View reviewed changes
Copy link
Member

@davids5 davids5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F4 my benefit from the same change.

@LorenzMeier LorenzMeier merged commit 7925787 into master Aug 31, 2021
@LorenzMeier LorenzMeier deleted the pr-px4io_serial_dma_race branch August 31, 2021 21:11
@taileron
Copy link
Contributor

taileron commented Sep 1, 2021

Can we tell what the cause of the stream error is?
Unfortunately, I have not yet been able to find the real cause. In any case, the PR cannot have a negative effect on my problem. Each U(S)ART only work without errors when TX and RX DMA are off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davids5 davids5 davids5 approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dagar @taileron @davids5 @LorenzMeier